Skip to content

Added CSendProxyRecipients function definitions to undefined_symbols.h.#371

Merged
jordanbriere merged 2 commits into
Source-Python-Dev-Team:masterfrom
CookStar:fix_header
Dec 10, 2020
Merged

Added CSendProxyRecipients function definitions to undefined_symbols.h.#371
jordanbriere merged 2 commits into
Source-Python-Dev-Team:masterfrom
CookStar:fix_header

Conversation

@CookStar

@CookStar CookStar commented Dec 8, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixed this error.

[Source.Python] Loading...
=========================================================================
[SP-LOADER] Could not load library: bin/core.so
[SP-LOADER] Error Reported: /home/steam/csgo_ds/csgo/addons/source-python/bin/core.so: undefined symbol: _ZN20CSendProxyRecipients12SetRecipientEi
=========================================================================
Failed to load plugin "addons/source-python"

Added Parts:

Source.Python/src/patches/csgo/public/dt_send.h

Lines 144 to 158 in 2669ced

inline void CSendProxyRecipients::SetRecipient( int iClient )
{
m_Bits.Set( iClient );
}
inline void CSendProxyRecipients::ClearRecipient( int iClient )
{
m_Bits.Clear( iClient );
}
inline void CSendProxyRecipients::SetOnly( int iClient )
{
m_Bits.ClearAll();
m_Bits.Set( iClient );
}

@CookStar CookStar changed the title Added missing functions in the header file. Added missing SendProxyRecipients functions in the header file. Dec 8, 2020
@jordanbriere

jordanbriere commented Dec 8, 2020

Copy link
Copy Markdown
Contributor

Fixed this error.

Thanks! However, no need to patch the whole file for missing symbols. Just add them to undefined_symbols.h. :)

@CookStar

CookStar commented Dec 8, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Fixed this error.

Thanks! However, no need to patch the whole file for missing symbols. Just add them to undefined_symbols.h. :)

Since all functions are inline member functions, this does not work.

@Ayuto

Ayuto commented Dec 8, 2020

Copy link
Copy Markdown
Member

Oh, I should have tested that. Thanks!

But you don't need to make them inline functions. Then adding them to the undefined symbols should work fine :)

@CookStar

CookStar commented Dec 8, 2020

Copy link
Copy Markdown
Contributor Author

But you don't need to make them inline functions. Then adding them to the undefined symbols should work fine :)

Okay.

@CookStar CookStar changed the title Added missing SendProxyRecipients functions in the header file. Added CSendProxyRecipients function definitions to undefined_symbols.h. Dec 9, 2020
@jordanbriere jordanbriere merged commit 5d02e54 into Source-Python-Dev-Team:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CookStar @jordanbriere @Ayuto